Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue #29 where browser path was not found on macOS #32

Merged
merged 3 commits into from
Mar 9, 2025

Conversation

CaioWzy
Copy link
Contributor

@CaioWzy CaioWzy commented Mar 9, 2025

  • Use platform.system() instead, os.name returns the same value whether it's Linux or macOS
  • Unit test and refactor some code

Copy link
Owner

@thalissonvs thalissonvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your contribution <3

@thalissonvs thalissonvs self-assigned this Mar 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
tests 97.42% <100.00%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pydoll/browser/chrome.py 93.33% <100.00%> (+93.33%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@thalissonvs thalissonvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run 'task format' to fix the ruff CI before merge

@CaioWzy
Copy link
Contributor Author

CaioWzy commented Mar 9, 2025

I guess there's something wrong with the formatter

image

@CaioWzy
Copy link
Contributor Author

CaioWzy commented Mar 9, 2025

It also touches other non-related lines

image

@thalissonvs
Copy link
Owner

I guess there's something wrong with the formatter

image

I'll take a look at the formatter. For now, can you undo those changes and just remove the space identified by the CI?

@thalissonvs thalissonvs assigned CaioWzy and unassigned thalissonvs Mar 9, 2025
@thalissonvs
Copy link
Owner

Good, thank you! I'll merge and create a new release

@thalissonvs thalissonvs merged commit 7b4ca78 into thalissonvs:main Mar 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants