Added object return type support for PHP 7.2

[benpitman]

If a method has object as the return type, which was introduced in PHP 7.2, the file will be omitted from the documentation.

This fix simply adds object to the array of valid return types.

[theseer]

Thanks!

[41646F6C666F]

Hello guys,
I've tested the last build and object types are no more parsables in that build, I'm right?

[theseer]

I woudln't know why it should stop working?

[41646F6C666F]

My bad. Only the return is blank when it's an object right?

[41646F6C666F]

Hello again guys,

After some more tests with objects types and well, I still not getting any object to show in the generated documentation.

When the object is a @return, it's just blank like this:

And when the object is one class or method's variable (@var and @param) it's also blank and break all the html with an open link :

Do you get the same result parsing objects types?

[theseer]

Looking at the template code it indeed looks like we're not handling "plain" object return types in a reasonable way.

Having had only a quick glance, it looks like we need to make the call to pdxf:link conditional on having additional information and otherwise simply output "object" - alternatively we'd have to change the implementation of pdxf:link.

@MacFJA Feel like enhancing this?

[MacFJA]

I can take a look at it in the next few days

[theseer]

Thanks a lot :)

[41646F6C666F]

Thank you guys!

[theseer]

PR merged. I'll add some other changes from my box and roll a new release early upcoming week.

[41646F6C666F]

PR merged. I'll add some other changes from my box and roll a new release early upcoming week.

Thank you so much. I'll try this new release as soon as it's up.

[jeroenrnl]

With this version (current HEAD of master), the output is not correct:

expected (created using 61615ed )

[41646F6C666F]

Good point @jeroenrnl but I tried your fix with the last master source and the methods still broken.

I think the issue is in the methods display, in the view file templates/html/synopsis.xsl between lines 106 & 137.

[jeroenrnl]

Good point @jeroenrnl but I tried your fix with the last master source and the methods still broken.

I think the issue is in the methods display, in the view file templates/html/synopsis.xsl between lines 106 & 137.

Thanks, but I didn't provide a fix :-)

[41646F6C666F]

Good point @jeroenrnl but I tried your fix with the last master source and the methods still broken.
I think the issue is in the methods display, in the view file templates/html/synopsis.xsl between lines 106 & 137.

Thanks, but I didn't provide a fix :-)

Well, I mean not "your" fix but the commit you mentioned hehe

[MacFJA]

My bad !
I left a debug line MacFJA@83d8d6c#diff-d8d68e01a6bc7227f7a2e8c17878f9adR60
I will fix it right now

[theseer]

Next try, please!

[41646F6C666F]

I confirm without the debug line it's good ;)

[jeroenrnl]

Yes! Works for me too! Thanks for the quick fix!