Fix typehint for callable #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactoring of types handling - Fix issue with last char removed on expression (theseer#313) Fix theseer#313, Fix theseer#233
|
I'm not really happy with now having a trait in phpDox. But the general docblock implementation hasn't aged very well ;) For now, i'll merge this as the implementation otherwise looks okay and I want this feature to be implemented. |
I see that phpDox don't have any trait.
I will check it this weekend, but I suspect some "conflict" with the PR #359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected result on
tests/data/issue313and ontests/data/issue233Fix #313, Fix #233