basic support bidirectional stream #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Aug 6, 2018
client.go
Outdated
| return 1 | ||
| } | ||
|
|
||
| func (c *Client) CallStream(opname string, req, resp Message, handleStream func(client *StreamClient) error) error { |
server.go
Outdated
| } | ||
| } | ||
|
|
||
| func (s *Server) handleRequest(wi *serverWorkItem, pendingResponses chan<- *serverWorkItem, stopCh <-chan struct{}) { | ||
| func (s *Server) handleRequest(wi *serverWorkItem, pendingResponses chan<- *serverWorkItem, stream *StreamServer, stopCh <-chan struct{}) { |
client.go
Outdated
| // | ||
| // This saves memory and CPU resources. | ||
|
|
||
| s := NewStreamClient(sid, xxhash.Sum64String(opname), c.opts.Codec, in, func(id uint32, m *request, resp chan error) { |
server.go
Outdated
| @@ -301,19 +374,63 @@ func (s *Server) connReader(br *bufio.Reader, pipeline bool, conn net.Conn, pend | |||
| } | |||
| continue | |||
| } | |||
|
|
|||
| var stream *StreamServer | |||
server.go
Outdated
| in := make(chan *request, 1) | ||
| streamID := binary.BigEndian.Uint32(wi.streamID[:]) | ||
| s.inStreamMsg[streamID] = in | ||
| stream = NewServerStream(streamID, s.opts.Codec, in, func(id uint32, m *response, resp chan error) { |
stream_test.go
Outdated
| var request = strconv.Itoa(t.N / 2) | ||
| var response = "" | ||
|
|
||
| err := c.CallStream("stream", &request, &response, func(client *StreamClient) error { |
stream_test.go
Outdated
| t.ResetTimer() | ||
| t.ReportAllocs() | ||
|
|
||
| err := client.SendMsg(request) |
There was a problem hiding this comment.
invalid operation: client (variable of type *invalid type) has no field or method SendMsg
stream_test.go
Outdated
| var r string | ||
|
|
||
| for i := 0; i < t.N/2; i++ { | ||
| err = client.RecvMsg(&r) |
There was a problem hiding this comment.
invalid operation: client (variable of type *invalid type) has no field or method RecvMsg
golangci
reviewed
Aug 6, 2018
| @@ -53,7 +53,7 @@ func (h *exposedCtx) Handle(ctxv *exposedCtx) (rctxv *exposedCtx) { | |||
| } | |||
| reply := opinfo.ReplyType() | |||
|
|
|||
| if err = handler(nil, args, reply); err != nil { | |||
| if err = handler(&Context{stream}, args, reply); err != nil { | |||
There was a problem hiding this comment.
github.com/thesyncim/exposed.Context composite literal uses unkeyed fields
client.go
Outdated
| ReleaseResponse(rawResp) | ||
| releaseClientWorkItem(wi) | ||
| c.decPendingRequests() | ||
| c.getError(err) |
There was a problem hiding this comment.
Error return value of c.getError is not checked
client.go
Outdated
| ReleaseResponse(rawResp) | ||
| releaseClientWorkItem(wi) | ||
| c.decPendingRequests() | ||
| c.getError(err) |
There was a problem hiding this comment.
Error return value of c.getError is not checked
client.go
Outdated
| ReleaseResponse(rawResp) | ||
| releaseClientWorkItem(wi) | ||
| c.decPendingRequests() | ||
| c.getError(err) |
There was a problem hiding this comment.
Error return value of c.getError is not checked
| codec encoding.Codec | ||
|
|
||
| inMessages chan *request | ||
| errOutCh chan error |
|
|
||
| type StreamClient struct { | ||
| ID uint32 | ||
| isServer bool |
stream.go
Outdated
| codec encoding.Codec | ||
|
|
||
| inMessages <-chan *response | ||
| errOutCh chan error |
client.go
Outdated
| @@ -159,6 +159,11 @@ type Client struct { | |||
| pendingResponses map[uint32]*clientWorkItem | |||
| pendingResponsesLock sync.Mutex | |||
|
|
|||
| incomingStreamMsg sync.Map | |||
| incomingStreamMsgLock sync.Mutex | |||
server.go
Outdated
| @@ -87,6 +88,10 @@ var defaultServerOptions = serverOptions{ | |||
| MaxBatchDelay: 0, | |||
| } | |||
|
|
|||
| var ( | |||
| typeUnarycall = []byte{byte(0)} | |||
stream_test.go
Outdated
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if i == 99 { |
make stream thread safe improve and reorganize code
golangci
reviewed
Aug 7, 2018
| @@ -236,23 +276,34 @@ func (s *Server) serveConn(conn net.Conn) error { | |||
| case err = <-readerDone: | |||
| conn.Close() | |||
| close(stopCh) | |||
| inStreamMsg.Range(func(key, value interface{}) bool { | |||
| panic("das") | |||
| close(value.(chan *request)) | |||
| <-writerDone | ||
| case err = <-writerDone: | ||
| conn.Close() | ||
| inStreamMsg.Range(func(key, value interface{}) bool { | ||
| panic("das") | ||
| close(value.(chan *request)) |
| streamMessage = packetControl(1) | ||
| streamStart = packetControl(2) | ||
| ///todo implement | ||
| streamClose = packetControl(3) |
| streamStart = packetControl(2) | ||
| ///todo implement | ||
| streamClose = packetControl(3) | ||
| streamCloseRead = packetControl(4) |
| ///todo implement | ||
| streamClose = packetControl(3) | ||
| streamCloseRead = packetControl(4) | ||
| streamCloseWrite = packetControl(5) |
| inMessages <-chan *response | ||
| serverOutMessages chan<- WorkItem | ||
|
|
||
| errOutCh chan error |
| codec encoding.Codec | ||
|
|
||
| inMessages <-chan *response | ||
| serverOutMessages chan<- WorkItem |
| reqID [4]byte | ||
| type serverUnaryWorkItem struct { | ||
| ctx *exposedCtx | ||
| startStream bool |
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if i == 99 { |
| }) | ||
| sid := c.nextStreamID() | ||
| inStream, _ := c.incomingStreamMsg.LoadOrStore(sid, make(chan *response, 100)) | ||
| var in chan *response |
There was a problem hiding this comment.
should merge variable declaration with assignment on next line
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
===========================================
- Coverage 66.84% 53.08% -13.77%
===========================================
Files 9 10 +1
Lines 926 1217 +291
===========================================
+ Hits 619 646 +27
- Misses 239 487 +248
- Partials 68 84 +16
Continue to review full report at Codecov.
|
Repository owner
deleted a comment from
i-am-yuvi
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.