Skip to content

feat: adds support for restore token #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

thiyaguk09
Copy link
Owner

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #support restoreToken

src/file.ts Outdated
@@ -3707,6 +3714,8 @@ class File extends ServiceObject<File, FileMetadata> {
* @param {string} [userProject] The ID of the project which will be
* billed for the request.
* @param {number} [generation] If present, selects a specific revision of this object.
* @param {string} [restoreToken] If this is a soft-deleted object in an HNS-enabled bucket, returns the restore token which will
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change description to be precise

Returns an option that must be specified when getting a soft-deleted object from an HNS-enabled bucket that has a name/generation conflict with another object in the same bucket.

@thiyaguk09 thiyaguk09 merged commit 9b890f1 into main Oct 25, 2024
8 checks passed
Copy link
Collaborator

@harsha-accenture harsha-accenture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants