Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge android-notification-channel-groups into develop #87

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Merge android-notification-channel-groups into develop #87

wants to merge 39 commits into from

Conversation

thomasgalliker
Copy link
Owner

@thomasgalliker thomasgalliker commented Oct 30, 2024 •
edited
Loading

Description

Create and delete notification channel groups. Assign groups to notification channels.

Issues

Checklist

  • General
    • The modified code fulfills the intended purpose and functions correctly.
    • Existing code continues to function without errors.
    • Performance has not been significantly impacted.
    • All TODOs in the code have been removed and, if necessary, recorded as follow-up tasks in Remine.
  • Testing
    • All existing unit tests pass successfully.
    • New functionalities are covered with unit tests.
    • Code coverage through unit tests has been verified.
    • Exploratory tests on real devices have been conducted on both platforms (iOS and Android).
  • Readability
    • Code style has been applied according to .editorconfig.
    • Naming conventions for variables and methods are clear and consistent.
  • Documentation
    • In-code comments are meaningful or replaced by self-explanatory code.
    • Changes to interfaces are documented in readme.md.
    • Updated the release notes under <PackageReleaseNotes>.
  • Security and Data Protection
    • Sensitive data is not unintentionally logged or stored.
    • User inputs have been validated.

@thomasgalliker thomasgalliker self-assigned this Oct 30, 2024
Thomas Galliker added 7 commits October 30, 2024 10:07
Merge remote-tracking branch 'origin/develop' into android-notificati…
e86119c 
…on-channel-groups

# Conflicts:
#	Plugin.FirebasePushNotifications/Platforms/Android/Channels/INotificationChannels.cs
#	Samples/MauiSampleApp/ViewModels/MainViewModel.cs
Internal refactoring of INotificationChannels implementation. Add API…
ac1a9e2 
… to manage notification channel groups in INotificationChannels.
Disable sentry by default
f72703b
Restore platform-independent implementation of INotificationChannels …
6ce6c32 
…to simplify dependency injection
Extend log messages
fb12adb
Fix log messages
fad9792
Add methods to open notification settings
165a8f0
@thomasgalliker thomasgalliker linked an issue Oct 31, 2024 that may be closed by this pull request
[Enhancement] Create Channels Group #56
Open
Thomas Galliker added 8 commits October 31, 2024 13:54
Remove prop set in android/ios specific options
ad9c1b8
Update release notes
8325e6b
Fix wrong label text
3dc547b
Fix bug in SetNotificationChannels so that no longer used channels ar…
2a2e443 
…e removed properly
Fix bug in SetNotificationChannelGroups to delete existing groups
c35a2ae
Set AutoInitEnabled=true by default
07810fd
Format enums in channel viewmodel
7c2f1fd
Merge remote-tracking branch 'origin/android-get-context-fix' into an…
ee3eb2e 
…droid-notification-channel-groups

# Conflicts:
#	Plugin.FirebasePushNotifications/Platforms/Android/FirebasePushNotificationManager.cs
#	Samples/MauiSampleApp/Views/ItemTemplates/NotificationChannelItemTemplate.xaml
#	Samples/MauiSampleApp/Views/MainPage.xaml
@thomasgalliker thomasgalliker mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomasgalliker thomasgalliker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Create Channels Group
1 participant
@thomasgalliker