Improves castInput to allow any JSON object as attribute value #16
+18
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #15 , this introduces a better way to parse attribute values provided by the user. Does so by leveraging
json.loads()
ability to identify and convert into Python equivalent any JSON object, including complex values like lists, objects etc. Doesn't break current single atomic values conversion, i.e.type(json.loads("1")) == int
,type(json.loads("true")) == bool
, etc.Before the suggested changes:
And after