Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for monet themed icons #68

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

starry-shivam
Copy link
Contributor

@starry-shivam starry-shivam commented May 31, 2024

While on that also:

  • Updated status bar background color to better match the device theme
  • JVM Target version to v17
  • Gradle Plugin to 8.X
  • Migrated from KAPT to KSP for room compiler plugin for much faster build times and more optimized code generation.

Screenshot_20240531_075835

Closes #59, Closes #51

@starry-shivam
Copy link
Contributor Author

@tirkarthi Pinging for review / comments.

@tirkarthi
Copy link
Owner

@starry-shivam Thanks for the PR and ping. I will review it this week.

@tirkarthi
Copy link
Owner

tirkarthi commented Jun 7, 2024

@starry-shivam I built the changes locally and it looks good to me. Couple of questions before I merge.

  1. I am using Nova launcher in Samsung A52 4G model. Is there a way to test adaptive icons using Nova or samsung launcher or could you please share the launcher you are using for the screenshot? Tested using Samsung launcher with custom color palette. Please ignore this question.
  2. Does bumping JDK version makes it not installable in some older devices or enforces some minimum Android version? I just went along with the defaults during project setup so wanted to check since I also publish the same codebase to fdroid.

@starry-shivam
Copy link
Contributor Author

Does bumping JDK version makes it not installable in some older devices or enforces some minimum Android version? I just went along with the defaults during project setup so wanted to check since I also publish the same codebase to fdroid.

It will work fine even on older devices because the generated bytecode is backwards compatible. Features specific to newer Java versions are made available to older Android's JVM/ART implementation with desugaring at build time. I bumped the JVM version because Gradle 8.x requires JVM 17. Additionally, many new Java APIs are also made available to older Android versions (up to Android 10, iirc) via project mainline with Google Play system updates. In those cases, desugaring isn't even required. Moreover, you aren't using any API specific to JVM 17 in the app that is not available in JVM 11 or 8, so none of these changes affect compatibility in this case.

@tirkarthi
Copy link
Owner

Thanks for the details. I also had to upgrade my old Android studio from Arctic fox to the latest version. I am planning some other changes and this will go as part of the next release.

Thank you for the contribution.

@tirkarthi tirkarthi merged commit 6e4ac5d into tirkarthi:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Add monochrome icon
2 participants