npm 버전 8.5이상으로 강제하고 node version을 17.7.0으로 변경합니다. #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
헉 모르고 테스트 릴리즈를 같이 포함시켜 버렸네요 .. ㅋㅋ 다시 푸쉬하겠습니다! |
pgs787
force-pushed
the
npm-version-engines
branch
from
3a3f708 to
4e0c35b
Compare
pgs787
changed the title
|
�node 17.6 버전 이상부터 npm 8.5를 지원해서 노드버전도 변경했습니다! |
Codecov Report
@@ Coverage Diff @@
## main #2004 +/- ##
=======================================
Coverage 30.61% 30.61%
=======================================
Files 545 545
Lines 10272 10272
Branches 3059 3059
=======================================
Hits 3145 3145
Misses 6857 6857
Partials 270 270 Continue to review full report at Codecov.
|
pgs787
added
help wanted
inbeom
reviewed
Mar 10, 2022
.github/workflows/cd.yaml
Outdated
| @@ -11,7 +11,7 @@ on: | |||
| env: | |||
| GITHUB_API_URL_BASE: https://api.github.com/repos/${{ github.repository }} | |||
| # Node.js | |||
| NODE_VERSION: '16.x' | |||
| NODE_VERSION: '17.6.x' | |||
There was a problem hiding this comment.
완전 블리딩엣지군요. 오늘 기준 current는 17.7.0이긴 하네요 https://nodejs.org/en/
There was a problem hiding this comment.
앗 그럼 17.7.0로 적용시키도록 하겠습니다! 🙇
polysiya
approved these changes
Mar 10, 2022
zhsks528
approved these changes
Mar 10, 2022
pgs787
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
Closes #1719
#1719 에 해당하는 이슈입니다.
lerna/lerna#2891 (comment)
npm 7.20 - 8.4 버전까지 TF 버전 업 시 package-lock.json가 업데이트 되지 않는 이슈가 있었습니다.
8.5이상 버전부터는 릴리즈 노트 내용과 같이 fix 되었습니다.
node 버전 업 (노드 문서)
npm version 8.5.0 이상을 지원하는 노드 버전이 17.6부터여서 노드 버전도 올리게 됐습니다.
위의 내용에 따라 npm 버전을 8.5이상으로 강제하여 이슈를 해결하고자 합니다.
변경 내역
체크리스트
스크린샷 & URL