Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi-version: add page #14770

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

nelsonfigueroa
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 10, 2024
@nelsonfigueroa nelsonfigueroa mentioned this pull request Nov 10, 2024
28 tasks
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, thanks for your contribution

Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#help-and-version-commands the two commands should be flipped, but IMO in this case we should leave it as is. Normally help/version commands are in a larger page and then placing help above version looks indeed better.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, however, i'd use the single quote character here

@spageektti spageektti merged commit bd130af into tldr-pages:main Nov 10, 2024
4 checks passed
@nelsonfigueroa nelsonfigueroa deleted the pulumi-version-add-page branch November 10, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants