Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi-config: add page #14820

Merged
merged 9 commits into from
Nov 27, 2024
Merged

pulumi-config: add page #14820

merged 9 commits into from
Nov 27, 2024

Conversation

Denis-Kuso
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 13, 2024
@sebastiaanspeck sebastiaanspeck mentioned this pull request Nov 14, 2024
28 tasks
Denis-Kuso and others added 2 commits November 14, 2024 08:30
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/pulumi-config.md:
Error: Parse error on line 30:
....}} {{{[`flags]}}`
---------------------^
Expecting 'NEWLINE', 'BACKTICK', got '1'
pages/common/pulumi-config.md:27: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution.

nelsonfigueroa and others added 2 commits November 23, 2024 18:52
Copy link
Collaborator

@nelsonfigueroa nelsonfigueroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Denis-Kuso It's been a while since there was activity here so I merged a couple of suggestions that were left for you. If you feel strongly about your original edits let us know. Otherwise, I think this is good to merge :)

@Denis-Kuso
Copy link
Contributor Author

Denis-Kuso commented Nov 24, 2024

I was sure those changes were accepted as a batch of suggested changes. Regardless, all is well. :)

Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after the suggestions are applied.

@spageektti spageektti closed this Nov 27, 2024
@spageektti spageektti reopened this Nov 27, 2024
@spageektti
Copy link
Member

Closes & reopened bc of  CLA test

@spageektti spageektti merged commit 4d161a8 into tldr-pages:main Nov 27, 2024
7 checks passed
BananaaaKING pushed a commit to BananaaaKING/tldr that referenced this pull request Jan 31, 2025
* pulumi-config: add page

* Apply suggestions from code review

Co-authored-by: Sebastiaan Speck <[email protected]>
config.md

---

Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Wiktor Perskawiec <[email protected]>
Co-authored-by: Nelson Figueroa <[email protected]>
Co-authored-by: Lena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants