Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages*/common/*: apply keypress specifications to translations #15905

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Mar 9, 2025

This can stay open for a longer time. I made some questionable substitutions by replacing plaintext translations with with the < > markings. Especially with korean. I located the words with a translator and then simply replaced the text.

See https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#keypress-syntax for guidelines. You are allowed to translate special characters.

@github-actions github-actions bot added mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s). labels Mar 9, 2025
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changes (including ko files). Overall it LGTM, the structure looks fine too.

@Managor
Copy link
Collaborator Author

Managor commented Mar 9, 2025

I added a note to the OP about translations.

Copy link
Member

@kant kant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish chapter: LGTM

@tldr-bot

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants