-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pages*/common/*: apply keypress specifications to translations #15905
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the changes (including ko files). Overall it LGTM, the structure looks fine too.
I added a note to the OP about translations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spanish chapter: LGTM
This can stay open for a longer time. I made some questionable substitutions by replacing plaintext translations with with the < > markings. Especially with korean. I located the words with a translator and then simply replaced the text.
See https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#keypress-syntax for guidelines. You are allowed to translate special characters.