-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tic: add page #3699
tic: add page #3699
Conversation
Hello! I've noticed something unusual when checking this PR:
Is this intended? If so, just ignore this comment. Otherwise, please |
989938c
to
2300a09
Compare
The build
Please fix the error(s) and push again. |
The build
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this even though there's only 1 example. Is there maybe some other tic's option that could be presented?
Looks like I have What about adding an example for the Either way, if you'd rather not we can always merge this PR and then create another one :-) |
It seems to be fine for me, including the new examples added after the suggestion made by @sbrl. This PR has the two required approvals and could be merged, but I prefer to wait until sbrl, as pending reviewer, check it. |
common/
,linux/
, etc.)