Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tic: add page #3699

Merged
merged 2 commits into from
Dec 30, 2019
Merged

tic: add page #3699

merged 2 commits into from
Dec 30, 2019

Conversation

jedahan
Copy link
Contributor

@jedahan jedahan commented Dec 27, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The file pages/linux/tic.info does not have a .md extension.

Is this intended? If so, just ignore this comment. Otherwise, please
double-check the commits.

@jedahan jedahan force-pushed the tic branch 2 times, most recently from 989938c to 2300a09 Compare December 27, 2019 19:59
@tldr-bot
Copy link

The build
for this PR failed with the following error(s):

pages/linux/tic.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build
for this PR failed with the following error(s):

pages/linux/tic.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

Copy link
Contributor

@zlatanvasovic zlatanvasovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this even though there's only 1 example. Is there maybe some other tic's option that could be presented?

@sbrl
Copy link
Member

sbrl commented Dec 28, 2019

Looks like I have tic installed - though I don't remember installing it myself :P

What about adding an example for the -c option, which only checks for errors but doesn't actually change anything? Or the -D option, which prints the database locations and then exits?

Either way, if you'd rather not we can always merge this PR and then create another one :-)

@einverne einverne added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Dec 28, 2019
@zlatanvasovic zlatanvasovic requested a review from sbrl December 28, 2019 17:47
@ivanhercaz
Copy link
Collaborator

It seems to be fine for me, including the new examples added after the suggestion made by @sbrl. This PR has the two required approvals and could be merged, but I prefer to wait until sbrl, as pending reviewer, check it.

@zlatanvasovic zlatanvasovic merged commit 7ac6008 into tldr-pages:master Dec 30, 2019
@Managor Managor mentioned this pull request Jan 29, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants