Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc-network, lxc-profile: add page #7280

Merged
merged 10 commits into from
Nov 6, 2021
Merged

Conversation

mtausig
Copy link
Contributor

@mtausig mtausig commented Oct 28, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

4.0.7

@mfrw mfrw added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 29, 2021
@navarroaxel navarroaxel added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 30, 2021
@navarroaxel navarroaxel changed the title lxc: Add subcommands network and profile lxc-network, lxc-profile: add page Oct 30, 2021
mtausig and others added 8 commits October 30, 2021 21:41
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtausig
Copy link
Contributor Author

mtausig commented Oct 30, 2021

Remember that you can apply all the suggestions using 1 commit with add to batch

Thanks, I overlooked that.
But nevermind, I'll just squash them when the reviews are done.

@navarroaxel
Copy link
Collaborator

@mtausig Don't worry, we squash when we merge.

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtausig
There are just a few minor things I'll quickly apply myself

@marchersimon marchersimon merged commit a60f1f9 into tldr-pages:main Nov 6, 2021
@Managor Managor mentioned this pull request Jan 19, 2025
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants