Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc: add page #8795

Merged
merged 11 commits into from
Oct 10, 2022
Merged

tc: add page #8795

merged 11 commits into from
Oct 10, 2022

Conversation

NimrodRak
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 7, 2022
einverne
einverne requested changes Oct 8, 2022
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NimrodRak Thank you for the new page. It seems that tc command is complex. I left some suggestions for you to take a look.

NimrodRak and others added 8 commits October 8, 2022 23:17
@NimrodRak
Copy link
Contributor Author

yup missed those, thx!

einverne
einverne approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@kbdharun kbdharun linked an issue Oct 9, 2022 that may be closed by this pull request
page request: traffic control #8794
Closed
5 tasks
kbdharun
kbdharun approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome to tldr and thanks for your contribution.

@kbdharun kbdharun requested a review from navarroaxel October 9, 2022 07:14
kbdharun
kbdharun reviewed Oct 10, 2022
View reviewed changes
@navarroaxel @kbdharun
Update pages/linux/tc.md
ad40e13 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@navarroaxel navarroaxel merged commit ce2f7d6 into tldr-pages:main Oct 10, 2022
@Managor Managor mentioned this pull request Jan 24, 2025
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

@einverne einverne einverne approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page request: traffic control
5 participants
@NimrodRak @CLAassistant @navarroaxel @einverne @kbdharun