Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify display_message #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify display_message #72

wants to merge 2 commits into from

Conversation

pahindman
Copy link

  • No scripts were passing the optional second parameter, so it would always use 5 seconds as the display time.
  • If we are going to continue to force the message to be displayed for 5 seconds then it would be better to make it apply to only this particular message by using the -d option rather than overriding display-time.
  • It might be better to respect the user's chosen display-time.

Phil Hindman added 2 commits March 1, 2025 19:00
Stop temporarily overriding display-time
08a274a 
Pass the desired display time to display-message using the -d option
instead of temporarily overriding the user's chosen display-time.
Display messages for the user's display-time
25cf980 
No callers pass a value for the second parameter, so it would always
display the message for 5 seconds.  Instead, respect the user's chosen
value for display-time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pahindman