test: fetch actions from mock handle before write #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2023 22:34
This covers the case when a Mock is created without any action, for use with an Handle. Refs: tokio-rs#5813
When creating a tokio_test::io::Mock with no actions, bew actions were never fetched from the mock Handle. This change fetches an action from the Handle, if present. Fixes: tokio-rs#5813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5813
When the Mock object is created without actions (such as for use with its Handle), it can happen that actions from the handle are never fetched, causing an unexpected broken pipe error.
Solution
Before executing the write, if there are no actions in the Mock, try receiving from the handle if an action is ready.