tracing: fix macro log support #304
Merged
+101
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
added
kind/bug
|
CI is broken for this branch due to an unrelated issue with the nightly-only examples that I have yet to figure out. Perhaps that build should be allowed to fail... |
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
turns out it is no longer necessary to match empty out sets separately if we are more lenient about commas being wherever... Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/fix-macro-log-support
branch
from
511208f to
4826c60
Compare
|
I think you mean "fixes #303" |
whoops, yeah, I do. fixed it! |
LucioFranco
approved these changes
Aug 30, 2019
hawkw
added a commit
that referenced
this pull request
Aug 30, 2019
Changed: - New (curly-brace free) event message syntax to place the message in the first field rather than the last (#309) Fixed: - Fixed a regression causing macro stack exhaustion when the `log` feature flag is enabled (#304) Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Aug 30, 2019
Changed: - New (curly-brace free) event message syntax to place the message in the first field rather than the last (#309) Fixed: - Fixed a regression causing macro stack exhaustion when the `log` feature flag is enabled (#304) Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#288 introduced a regression that causes infinite macro recursion when
the
logfeature is enabled. This PR fixes it (by making the macrossignificantly worse).
I've also added a new test step that runs with
--all-features, sinceapparently CI doesn't already do this.
Fixes #303