switch from new Buffer() to Buffer.from()

[starpit]

avoids deprecation failures in nodejs 10

Fixes #256

[tomas]

Nice, thanks! I think we'd need to update the package.json definition to declare that from now on, Needle requires at least Node v4.4.x (that's when I believe Buffer.from was introduced).

[starpit]

https://nodejs.org/api/buffer.html#buffer_class_method_buffer_from_string_encoding

from: 5.10.0

is that OK?

[starpit]

updated package.json

[tomas]

That's weird, according to earlier docs it was added in 3.0.0?

https://nodejs.org/docs/v4.5.0/api/buffer.html#buffer_class_method_buffer_from_array

[starpit]

that is Buffer.from(array); we will need Buffer.from(string, encoding?)

[tomas]

Sorry, wrong link. I meant https://nodejs.org/docs/v4.5.0/api/buffer.html#buffer_class_method_buffer_from_str_encoding

[starpit]

huh, weird! i can update the PR to reflect this. thanks!

[starpit]

done. it's sad i guess that we have to drop support for older releases, but the alternative is failures on node 10 :(

[DaTebe]

When do you guys plan to merge this PR?

[tomas]

Next week! :)

[DaTebe]

Hi, any chance we get a new release including this merge?
Kind regards

[tomas]

Yes! Sorry, I've been a bit super busy with other stuff lately.

[tomas]

Done! Just published 2.3.0