Upgrade to Webpack 5 #192
Merged
Upgrade to Webpack 5 #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Thank you @nickmoreton! All working as expected as far as I can see. It seems we could remove more from the Webpack configuration with this Highlight.js release, so I’ll add that on top of your changes.
| }); | ||
| hljs.registerLanguage('django', django); | ||
| hljs.registerLanguage('yaml', yaml); | ||
| hljs.highlightAll(); | ||
| } |
There was a problem hiding this comment.
With this change, it seems the webpack.config.js overrides for highlight.js are now irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Webpack 5 and also update all other dependencies
In https://github.com/torchbox/django-pattern-library/blob/main/pattern_library/static/pattern_library/src/js/components/syntax-highlighting.js
initHighlightingOnLoad()has been changed tohighlightAll()I have also refactored the exported function which didn't work when upgrading
highlight.jsto v11 +Fixes #183 in part.
Checklist