Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in tox 3.21 #1785

Closed
AntoineD opened this issue Jan 10, 2021 · 4 comments · Fixed by #1796
Closed

Regression in tox 3.21 #1785

AntoineD opened this issue Jan 10, 2021 · 4 comments · Fixed by #1796
Labels
bug:normal affects many people or has quite an impact

Comments

@AntoineD
Copy link
Contributor

It looks like tox 3.21 is swallowing whatever comes after a : inside curly braces.

For instance, with the tox.ini from tox-conda:

commands =
    pytest {posargs: \
      --junitxml {toxworkdir}/junit.{envname}.xml --cov {envsitepackagesdir}/tox_conda --cov tests \
      --cov-config=tox.ini --no-cov-on-fail --cov-report term-missing --cov-context=test \
      --cov-report html:{envtmpdir}/htmlcov \
      --cov-report xml:{toxworkdir}/coverage.{envname}.xml \
      tests --timeout 180 --durations 5}

With tox 3.20 is executed:

py39 run-test: commands[0] | pytest --junitxml /home/antoine.dechaume/tox-conda/.tox/junit.py39.xml --cov /home/antoine.dechaume/tox-conda/.tox/py39/lib/python3.9/site-packages/tox_conda --cov tests --cov-config=tox.ini --no-cov-on-fail --cov-report term-missing --cov-context=test --cov-report html:/home/antoine.dechaume/tox-conda/.tox/py39/tmp/htmlcov --cov-report xml:/home/antoine.dechaume/tox-conda/.tox/coverage.py39.xml tests --timeout 180 --durations 5

But with 3.21 we get:

py39 run-test: commands[0] | pytest --junitxml /home/antoine.dechaume/tox-conda/.tox/junit.py39.xml --cov /home/antoine.dechaume/tox-conda/.tox/py39/lib/python3.9/site-packages/tox_conda --cov tests --cov-config=tox.ini --no-cov-on-fail --cov-report term-missing --cov-context=test --cov-report html
@AntoineD AntoineD added the bug:normal affects many people or has quite an impact label Jan 10, 2021
@gaborbernat
Copy link
Member

@jayvdb I think this is also because of your changes if you can take a look 👏

@jayvdb
Copy link

jayvdb commented Jan 11, 2021

yup, probably #1715

@jayvdb
Copy link

jayvdb commented Jan 11, 2021

Another one caused by #1697

jayvdb added a commit to jayvdb/tox that referenced this issue Jan 11, 2021
e4d0d60 introduced a regression when posargs default
contained a colon, as the common substitution arg
regex splits on the colon, and uses different replace
types depending on the number of colons found.

Fixes tox-dev#1785
jayvdb added a commit to jayvdb/tox that referenced this issue Jan 11, 2021
e4d0d60 introduced a regression when posargs default
contained a colon, as the common substitution arg
regex splits on the colon, and uses different replace
types depending on the number of colons found.

Fixes tox-dev#1785
@jayvdb jayvdb mentioned this issue Jan 11, 2021
6 tasks
@gaborbernat
Copy link
Member

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
e4d0d60 introduced a regression when posargs default
contained a colon, as the common substitution arg
regex splits on the colon, and uses different replace
types depending on the number of colons found.

Fixes tox-dev#1785
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug:normal affects many people or has quite an impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants