Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tomllib from the standard library on Python 3.11+ #2462

Closed
hroncok opened this issue Jul 21, 2022 · 4 comments · Fixed by #2463
Closed

Use tomllib from the standard library on Python 3.11+ #2462

hroncok opened this issue Jul 21, 2022 · 4 comments · Fixed by #2463
Labels
feature:new something does not exist yet, but should

Comments

@hroncok
Copy link
Contributor

hroncok commented Jul 21, 2022

Hey,
would you accept a pull request that uses tomllib rom the standard library on Python 3.11+ and fallbacks to tomli, instead of toml?
@hroncok hroncok added the feature:new something does not exist yet, but should label Jul 21, 2022
hroncok added a commit to hroncok/tox that referenced this issue Jul 21, 2022
@hroncok
Use tomllib from the standard library on Python 3.11+
0503940 
Fallback to tomli, which has the same API.

Fixes tox-dev#2462
@hroncok hroncok mentioned this issue Jul 21, 2022
Merged
6 tasks
@hroncok
Copy link
Contributor Author

hroncok commented Jul 21, 2022

I was testing the changes, so I opened a draft PR without a changelog entry to present what change I meant. If acceptable, I'll add the entry. #2463

@jugmac00
Copy link
Member

Looks like tomli never had support for Python 2.7. I am not sure what are the plans about that in the future. tox4 will require Python 3.7 as a minimum, but I don't think it makes a lot of sense to drop support for Python 2.7 for tox 3 anymore.

@hroncok
Copy link
Contributor Author

hroncok commented Jul 22, 2022

I have not thought about that. Will fallback to toml. Not today though.

@hroncok
Copy link
Contributor Author

hroncok commented Jul 24, 2022

Done.

gaborbernat pushed a commit to hroncok/tox that referenced this issue Aug 21, 2022
@hroncok @gaborbernat
Use tomllib from the standard library on Python 3.11+
f8d10c5 
Fallback to tomli, which has the same API.

Fixes tox-dev#2462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:new something does not exist yet, but should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tomllib from the standard library on Python 3.11+ hroncok/tox
2 participants
@hroncok @jugmac00