Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--result-json does not respect --skip-missing-interpreters-option #672

Closed
r2dan opened this issue Nov 15, 2017 · 2 comments
Closed

--result-json does not respect --skip-missing-interpreters-option #672

r2dan opened this issue Nov 15, 2017 · 2 comments
Labels
area:reporting bug:normal affects many people or has quite an impact level:easy rought estimate that this might be quite easy to implement

Comments

@r2dan
Copy link

r2dan commented Nov 15, 2017

When executing tox with --result-json and --skip-missing-interpreters-option, the latter seems not to be reflected in the generated json file. Please find the sample project attached below:
missing_interpreters.tar.gz

To reproduce the issue simply invoke:

tox --skip-missing-interpreters --result-json toxreport.json
Tox main process exits with return code 0, but in toxreport.json file user can see the following:

"python": {
  "setup": [
  {
    "command": [
    "setup virtualenv"
    ],
    "output": "InterpreterNotFound: xyz_unknown_interpreter",
    "retcode": "1"
   }
   ]
}

In my opinion retcode here should be changed to 0 if --skip-missing-interpreters option is explicitly used.

@r2dan r2dan changed the title --result-log does not respect --skip-missing-interpreters-option --result-json does not respect --skip-missing-interpreters-option Nov 15, 2017
@obestwalter
Copy link
Member

Hi @r2dan thanks for the report. Having a test reproducing this would also be great.

@obestwalter obestwalter added area:reporting bug:normal affects many people or has quite an impact level:easy rought estimate that this might be quite easy to implement needs:reproducer ideally a failing test marked as xfail. If that is not possible exact instructions to reproduce labels Nov 17, 2017
@r2dan
Copy link
Author

r2dan commented Jan 5, 2018

Sorry for a long radio silence - the test (and PR) is ready. Thanks!

@obestwalter obestwalter removed the needs:reproducer ideally a failing test marked as xfail. If that is not possible exact instructions to reproduce label Jan 5, 2018
gaborbernat pushed a commit that referenced this issue Jan 11, 2018
…ixes #672  (#726)

* Fix generation of JSON files with --skip-missing-interpreters option.

* reverting accidental formatting change
gaborbernat pushed a commit that referenced this issue Jan 4, 2019
Related to:
1. #672 --result-json does not respect --skip-missing-interpreters-option
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:reporting bug:normal affects many people or has quite an impact level:easy rought estimate that this might be quite easy to implement
Projects
None yet
Development

No branches or pull requests

2 participants