-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with incorrectly defactorized dependencies #706 #1058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments from #1057.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartsanchez note the ci failed with formatting, plus comments from #1057
New version with improved changes, fixing errors raised with the previous version: tox-dev#899 tox-dev#906
I've updated the PR. Please, let me know if anything else should be changed. |
will do tomorrow or so 😃 |
@bartsanchez now looks all good, thank you very much for your collaboration and time! |
New version with improved changes, fixing errors raised
with the previous version:
#899
#906
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
superuser
."CONTRIBUTORS
(preserving alphabetical order)