Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with incorrectly defactorized dependencies #706 #1058

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

bartsanchez
Copy link

@bartsanchez bartsanchez commented Oct 14, 2018

New version with improved changes, fixing errors raised
with the previous version:

#899
#906

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if pr has no issue: consider creating one first or change it to the pr number after creating the pr
    • "sign" fragment with "by @"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments from #1057.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartsanchez note the ci failed with formatting, plus comments from #1057

@bartsanchez bartsanchez changed the title Fix bug with incorrectly defactorized dependencies #706 WIP Fix bug with incorrectly defactorized dependencies #706 Oct 14, 2018
@bartsanchez bartsanchez changed the title WIP Fix bug with incorrectly defactorized dependencies #706 Fix bug with incorrectly defactorized dependencies #706 Oct 20, 2018
New version with improved changes, fixing errors raised
with the previous version:

tox-dev#899
tox-dev#906
@bartsanchez
Copy link
Author

I've updated the PR. Please, let me know if anything else should be changed.

@gaborbernat
Copy link
Member

will do tomorrow or so 😃

@gaborbernat gaborbernat added this to the 3.6 milestone Oct 21, 2018
@gaborbernat gaborbernat merged commit c611a16 into tox-dev:master Oct 21, 2018
@gaborbernat
Copy link
Member

@bartsanchez now looks all good, thank you very much for your collaboration and time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants