Allow to use --devenv without tox config #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
hroncok
commented
Aug 6, 2020
| @@ -1056,7 +1061,7 @@ class ParseIni(object): | |||
| def __init__(self, config, ini_path, ini_data): # noqa | |||
| config.toxinipath = ini_path | |||
| using("tox.ini: {} (pid {})".format(config.toxinipath, os.getpid())) | |||
| config.toxinidir = config.toxinipath.dirpath() | |||
| config.toxinidir = config.toxinipath.dirpath() if ini_path.check(file=True) else ini_path | |||
There was a problem hiding this comment.
Note that this feels a bit like a hack. I've tried to pass None and adapt the code to not do certain things if this is None, but it was too messy.
gaborbernat
approved these changes
Aug 6, 2020
hroncok
changed the title
hroncok
force-pushed
the
devenv_sans_config
branch
from
bd6bf8c to
23ea4fd
Compare
|
I'll defer review and merge on this to my co-maintainer @asottile as he's the champion of this feature. But at a high level, I'm happy with what I see here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1643
Contribution checklist:
(also see CONTRIBUTING.rst for details)
CONTRIBUTORS(preserving alphabetical order)