Fixing #571. skip_install should override usedevelop #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Do we have a bug fo that centos7 thing already? |
|
ahh ... upstream bug - ok. |
|
@ferdonline I want to make a release from the existing PRs now. I won't merge this yet, as I am hoping for a bit more feedback about this and we have quite a lot of changes merged already for the next release. But I really don't want too much time pass between releases anymore, so this will be out soonish if no objections to this change pop up. |
|
Alright! Thanks for keeping me up to date! 👍 |
obestwalter
added
area:configuration
feature:change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in #270 one realises the need of supporting both skip_install and usedevelop together, with skip_install having priority (usedevelop being considered as an install option).
This PR implements such change.
For the tests to run also in py27 it was necessary to fix using FileNotFoundError
Also, in centos7 virtualenv alwayscopy is broken, so for the moment it detects the platform and skips the test.
Fixes #571