-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#614] add towncrier to manage changelog additions #615
Conversation
gaborbernat
commented
Sep 8, 2017
•
edited
Loading
edited
- also moved Let skip_install override usedevelop instead of the other way around #571 documentation to news fragment as demonstration
- extended the documentation build to automatically prepend the current new fragments to the changelog, this way news fragments are also subject to the CI operations, but otherwise when we do a release (and there are no news staged don't get in the way)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM let's start using it :)
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 11 11
Lines 2391 2391
=======================================
Hits 2209 2209
Misses 182 182 Continue to review full report at Codecov.
|
hmmm, still WIP, I need to elevate the header level first |
the whaddy what what? o.k. go ahead, I have no clue yet how it really works :) |
Ok now should be fine; let's wait for the CI to confirm this. The problem was that now we generate an additional level of headers by town crier, the four big groups. |
Great. I am really looking forward to start using this. The manual way was a major PITA. ... and it will look much nicer wherever we put this. One thing I just thought of: the little helper I built to generate the long description is not needed anymore then: Lines 41 to 63 in 952385a
We should get rid of that right away, before we forget that it' obsolete :) |
would be something like that then:
|
@obestwalter there's a filtering step in there, like taking last 5 releases which you removed; but otherwise true 👍 |
not needed anymore now we have towncrier.
changed it in branch (hopefully did not mess it up, did it in web editor). |
full changelog is o.k. I guess. |
otherwise, we can readd it later, just want to makw sure we git rid of old busted stuff right away |
tox.ini
Outdated
@@ -24,6 +24,7 @@ commands = {posargs:py.test -s -x -f -v} | |||
description = invoke sphinx-build and try to build the HTML page, and check that URIs are valid | |||
basepython = python | |||
deps = sphinx >= 1.6.3, < 2 | |||
towncrier >= 17.8.0, < 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
towncrier uses calver, so that version block is not sensible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, will remove it!
mac is awfully slow these days. Anyway let's merge this. |
Yeah, Travis had some issues: https://www.traviscistatus.com/ |