Touch up tests #687
Merged
Touch up tests #687
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
approved these changes
Nov 29, 2017
|
Why not merge it before? It's not like it makes anything worse for the stuff already failing 😉 |
|
Makes the little green badge turn red, shrugs it's probably fine to merge :P |
|
mergy mergy? :-) so we can start on reviewing the issue #292 pull request (currently a temporary pull request is up for review at jurko-gospodnetic#1) |
|
@jurko-gospodnetic fixup the conflict, and let's see how the CI reacts |
Requested environments are not recognized unless all of their factors are listed somewhere in some read configuration file section or built into tox itself.
jurko-gospodnetic
force-pushed
the
touch-up-tests
branch
from
82732d6 to
5efadf5
Compare
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 11 11
Lines 2371 2371
Branches 402 402
=======================================
Hits 2121 2121
Misses 175 175
Partials 75 75Continue to review full report at Codecov.
|
|
@gaborbernat - fix branch rebased on top of the current |
asottile
approved these changes
Dec 1, 2017
gaborbernat
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touched up some test code while researching where to add tests for some other work in progress.
removed commented out debugging code
removed commented out checks that already has a valid alternative
replaced commented out checks with valid alternatives where missing
extended
test_config_parse_platform_with_factors()with a missing checkadded
test_envconfigs_based_on_factors()showing how requested environment names are interpreted based on which environment name factors we have defined in the tox configuration