Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change favicon to the vector beach ball #764

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

hazalozturk
Copy link

Issue #748.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if pr has no issue: consider creating one first or change it to the pr number after creating the pr
    • "sign" fragment with "by @"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by @superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@hazalozturk
Copy link
Author

@obestwalter I changed the favicon to the vector beach ball. This definitely looks better as you stated! I am also including a zip file with a set of favicons for various devices. Let me know if I can help with other things.

toxFavicons.zip

@codecov
Copy link

codecov bot commented Feb 10, 2018

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          11       11           
  Lines        2397     2397           
=======================================
  Hits         2273     2273           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1db8a8...8662799. Read the comment docs.

@gaborbernat gaborbernat merged commit 13beb8b into tox-dev:master Feb 12, 2018
@gaborbernat
Copy link
Member

@hazalozturk thanks!

@webknjaz
Copy link
Contributor

Hey, @hazalozturk would it be possible to have an SVG version of the ball alone committed? The "ico" format is a bitmap and doesn't scale well. Modern browsers support vector favicons just fine so it'd be nice to have it in such a format.

P.S. I just realized that the RTD website doesn't actually expose this icon because it's not integrated with Sphinx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants