Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with incorrectly defactorized dependencies #768

Conversation

bartsanchez
Copy link

@bartsanchez bartsanchez commented Mar 2, 2018

#706

By performing dependencies replacement before applying factors,
since previously this function was being incorrectly called with
unrolled dependencies.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if pr has no issue: consider creating one first or change it to the pr number after creating the pr
    • "sign" fragment with "by @"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by @superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

tox-dev#706

By performing dependencies replacement before applying factors,
since previously this function was being incorrectly called with
unrolled dependencies.
@bartsanchez
Copy link
Author

Closing PR since I've force-updated my changes and PR seems to be unrecognizing new changes.

bartsanchez added a commit to bartsanchez/tox that referenced this pull request Oct 14, 2018
New version with improved changes, fixing errors raised
with the previous version:

tox-dev#899
tox-dev#906
bartsanchez added a commit to bartsanchez/tox that referenced this pull request Oct 14, 2018
New version with improved changes, fixing errors raised
with the previous version:

tox-dev#899
tox-dev#906
bartsanchez added a commit to bartsanchez/tox that referenced this pull request Oct 14, 2018
New version with improved changes, fixing errors raised
with the previous version:

tox-dev#899
tox-dev#906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant