Ability to specify package requirements for the tox run #783 #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done via the ``tox.ini`` (``tox`` section under key ``requires`` - PEP-508 style). Can be used to specify both plugin requirements or build dependencies until we'll have PEP-517 support. Using ``pkg_resources.Requirement``. Note tox will refuse to run if cannot satisfy dependencies. It's the users responsibility to ensure dependencies are satisfied. ``pkg_resources`` is part of setuptools so added setuptools as dependency. Realized pkg_resources contain everything we used from packaging, dropped packaging as dependency.
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
+ Coverage 92.81% 92.98% +0.16%
==========================================
Files 12 12
Lines 2367 2495 +128
Branches 412 471 +59
==========================================
+ Hits 2197 2320 +123
- Misses 108 111 +3
- Partials 62 64 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done via the
tox.ini(toxsection under keyrequires- PEP-508style). Can be used to specify both plugin requirements or build
dependencies until we'll have PEP-517 support.
Using
pkg_resources.Requirement. Note tox will refuse to run ifcannot satisfy dependencies. It's the users responsibility to ensure
dependencies are satisfied.
pkg_resourcesis part of setuptools soadded setuptools as dependency.
Realized pkg_resources contain everything we used from packaging,
dropped packaging as a dependency.