Onestop IDs shouldn't have capital letters #1256

drewda · 2024-10-03T20:46:41Z

No description provided.

drewda · 2024-10-03T23:12:27Z

github-actions · 2025-03-13T20:39:57Z

DMFR Format Check Results

This PR includes files that need formatting adjustments to follow the "opinionated" DMFR format.

Suggested Changes:

diff --git a/feeds/armadina.hu.dmfr.json b/feeds/armadina.hu.dmfr.json
index e280a572..f81b7570 100644
--- a/feeds/armadina.hu.dmfr.json
+++ b/feeds/armadina.hu.dmfr.json
@@ -3,6 +3,9 @@
   "feeds": [
     {
       "id": "f-u2mmz-budaörsvárosönkormányzata",
+      "supersedes_ids": [
+        "f-u2mmz-budaörsvárosÖnkormányzata"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://armadina-transit.fra1.digitaloceanspaces.com/budaors.zip",
@@ -16,9 +19,6 @@
           "name": "Budaörs Város Önkormányzata",
           "website": "http://www.budaors.hu/"
         }
-      ],
-      "supersedes_ids": [
-        "f-u2mmz-budaörsvárosÖnkormányzata"
       ]
     }
   ],
diff --git a/feeds/datahub.io.dmfr.json b/feeds/datahub.io.dmfr.json
index 4d3d4ee4..f579c6d3 100644
--- a/feeds/datahub.io.dmfr.json
+++ b/feeds/datahub.io.dmfr.json
@@ -3,6 +3,9 @@
   "feeds": [
     {
       "id": "f-sgg5z-gr~προστιακόςσιδηρόδρομοςπατρών",
+      "supersedes_ids": [
+        "f-sgg5z-gr~ΠροστιακόςΣιδηρόδρομοςΠατρών"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://datahub.io/angelou/proastiakos-patras-gtfs-20171128/r/prostiakos-patras-gtfs-20171128.zip"
@@ -19,13 +22,13 @@
             }
           ]
         }
-      ],
-      "supersedes_ids": [
-        "f-sgg5z-gr~ΠροστιακόςΣιδηρόδρομοςΠατρών"
       ]
     },
     {
       "id": "f-sqz-greece~κτελνzακυνθουαε",
+      "supersedes_ids": [
+        "f-sqz-greece~ΚΤΕΛΝzΑΚΥΝΘΟΥΑΕ"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://datahub.io/angelou/ktel-zakynthou-gtfs-20171128/r/ktel-zakynthou-gtfs-20171128.zip"
@@ -41,13 +44,13 @@
             }
           ]
         }
-      ],
-      "supersedes_ids": [
-        "f-sqz-greece~ΚΤΕΛΝzΑΚΥΝΘΟΥΑΕ"
       ]
     },
     {
       "id": "f-sqz-greece~υπεραστικοκτελνθεσπρωτιας",
+      "supersedes_ids": [
+        "f-sqz-greece~ΥΠΕΡΑΣΤΙΚΟΚΤΕΛΝΘΕΣΠΡΩΤΙΑΣ"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://datahub.io/angelou/ktel-thesprotias-gtfs-20171128/r/ktel-thesprotias-gtfs-20171128.zip"
@@ -63,9 +66,6 @@
             }
           ]
         }
-      ],
-      "supersedes_ids": [
-        "f-sqz-greece~ΥΠΕΡΑΣΤΙΚΟΚΤΕΛΝΘΕΣΠΡΩΤΙΑΣ"
       ]
     },
     {
diff --git a/feeds/dev.hsl.fi.dmfr.json b/feeds/dev.hsl.fi.dmfr.json
index cb204085..77f95e0c 100644
--- a/feeds/dev.hsl.fi.dmfr.json
+++ b/feeds/dev.hsl.fi.dmfr.json
@@ -192,6 +192,9 @@
     },
     {
       "id": "f-ue4-jyväskylänliikenneoy~koivurantaoy~tilausajotmennäänbussill",
+      "supersedes_ids": [
+        "f-ue4-jyväskylänliikenneoy~koivurantaoy~tilausajotmennÄÄnbussill"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://tvv.fra1.digitaloceanspaces.com/209.zip",
@@ -202,10 +205,7 @@
       "license": {
         "spdx_identifier": "CC-BY-4.0",
         "url": "https://opendata.waltti.fi/docs#gtfs-static-packages"
-      },
-      "supersedes_ids": [
-        "f-ue4-jyväskylänliikenneoy~koivurantaoy~tilausajotmennÄÄnbussill"
-      ]
+      }
     },
     {
       "id": "f-ue4d-savonlinjaoy",
diff --git a/feeds/geodata.gov.gr.dmfr.json b/feeds/geodata.gov.gr.dmfr.json
index 978bf4e0..789044d7 100644
--- a/feeds/geodata.gov.gr.dmfr.json
+++ b/feeds/geodata.gov.gr.dmfr.json
@@ -3,6 +3,9 @@
   "feeds": [
     {
       "id": "f-swb-οργανισμόςαστικώνσυγκοινωνιώνοασα~αthensurbantransportorga",
+      "supersedes_ids": [
+        "f-swb-ΟργανισμόςΑστικώνΣυγκοινωνιώνΟΑΣΑ~Αthensurbantransportorga"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "http://geodata.gov.gr/dataset/244cfb87-21a0-4f9f-90af-25e9a232af41/resource/d94179a0-a2bd-432f-8c5e-e05eae2886cf/download/googletransit.zip"
@@ -13,9 +16,6 @@
           "name": "Οργανισμός Αστικών Συγκοινωνιών ΟΑΣΑ - Αthens Urban Transport Organisation",
           "website": "http://www.oasa.gr"
         }
-      ],
-      "supersedes_ids": [
-        "f-swb-ΟργανισμόςΑστικώνΣυγκοινωνιώνΟΑΣΑ~Αthensurbantransportorga"
       ]
     }
   ],
diff --git a/feeds/mkuran.pl.dmfr.json b/feeds/mkuran.pl.dmfr.json
index 692b74cb..1c4d3b67 100644
--- a/feeds/mkuran.pl.dmfr.json
+++ b/feeds/mkuran.pl.dmfr.json
@@ -326,6 +326,9 @@
     },
     {
       "id": "f-u3qc-komunikacjamiejskałomiankispzoo",
+      "supersedes_ids": [
+        "f-u3qc-komunikacjamiejskaŁomiankispzoo"
+      ],
       "name": "Łomianki GTFS",
       "spec": "gtfs",
       "urls": {
@@ -351,9 +354,6 @@
           "short_name": "KMŁ",
           "website": "http://kmlomianki.info/"
         }
-      ],
-      "supersedes_ids": [
-        "f-u3qc-komunikacjamiejskaŁomiankispzoo"
       ]
     },
     {
diff --git a/feeds/navarra.es.dmfr.json b/feeds/navarra.es.dmfr.json
index 1c28f3cf..d98d48dc 100644
--- a/feeds/navarra.es.dmfr.json
+++ b/feeds/navarra.es.dmfr.json
@@ -3,6 +3,9 @@
   "feeds": [
     {
       "id": "f-ezw-automóvilesríoalhamasa~elcartelabargaalberto~autobusesparr",
+      "supersedes_ids": [
+        "f-ezw-automÓvilesrÍoalhamasa~elcartelabargaalberto~autobusesparr"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://datosabiertos.navarra.es/es/dataset/ebfb5edd-0cd9-4b31-b0d9-8bc2d25e2493/resource/d3c1c89a-5d4c-4c25-97b5-66da663d3691/download/gtfs.zip",
@@ -208,9 +211,6 @@
             }
           ]
         }
-      ],
-      "supersedes_ids": [
-        "f-ezw-automÓvilesrÍoalhamasa~elcartelabargaalberto~autobusesparr"
       ]
     }
   ],
diff --git a/feeds/peatus.ee.dmfr.json b/feeds/peatus.ee.dmfr.json
index f9f9bc5e..0134072b 100644
--- a/feeds/peatus.ee.dmfr.json
+++ b/feeds/peatus.ee.dmfr.json
@@ -3,6 +3,9 @@
   "feeds": [
     {
       "id": "f-ud-atkoliinidoü~aktsiaseltshansabussiliinid~kihnuveeteedas~väi",
+      "supersedes_ids": [
+        "f-ud-atkoliinidoÜ~aktsiaseltshansabussiliinid~kihnuveeteedas~väi"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "http://www.peatus.ee/gtfs/gtfs.zip"
@@ -618,9 +621,6 @@
             }
           ]
         }
-      ],
-      "supersedes_ids": [
-        "f-ud-atkoliinidoÜ~aktsiaseltshansabussiliinid~kihnuveeteedas~väi"
       ]
     }
   ],
diff --git a/feeds/porolakka.github.com.dmfr.json b/feeds/porolakka.github.com.dmfr.json
index 3a474178..9de972bf 100644
--- a/feeds/porolakka.github.com.dmfr.json
+++ b/feeds/porolakka.github.com.dmfr.json
@@ -3,6 +3,9 @@
   "feeds": [
     {
       "id": "f-hanedainl_shuttlebus20230528",
+      "supersedes_ids": [
+        "f-HanedaINL_ShuttleBus20230528"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://github.com/porolakka/TokyoINTL_FSB_gtfs-test_20230528/raw/main/gtfs.zip"
@@ -21,9 +24,6 @@
             }
           ]
         }
-      ],
-      "supersedes_ids": [
-        "f-HanedaINL_ShuttleBus20230528"
       ]
     }
   ],
diff --git a/feeds/stops.lt.dmfr.json b/feeds/stops.lt.dmfr.json
index a606adfc..a33beeea 100644
--- a/feeds/stops.lt.dmfr.json
+++ b/feeds/stops.lt.dmfr.json
@@ -52,6 +52,9 @@
     },
     {
       "id": "f-u99z-sįsusisiekimopaslaugos",
+      "supersedes_ids": [
+        "f-u99z-sĮsusisiekimopaslaugos"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "https://www.stops.lt/vilnius/vilnius/gtfs.zip",
@@ -61,21 +64,18 @@
       },
       "tags": {
         "exclude_from_global_query": "true"
-      },
-      "supersedes_ids": [
-        "f-u99z-sĮsusisiekimopaslaugos"
-      ]
+      }
     },
     {
       "id": "f-u99z-sįsusisiekimopaslaugos~rt",
+      "supersedes_ids": [
+        "f-u99z-sĮsusisiekimopaslaugos~rt"
+      ],
       "spec": "gtfs-rt",
       "urls": {
         "realtime_vehicle_positions": "https://www.stops.lt/vilnius/gtfs_realtime.pb",
         "realtime_trip_updates": "https://www.stops.lt/vilnius/gtfs_realtime.pb"
-      },
-      "supersedes_ids": [
-        "f-u99z-sĮsusisiekimopaslaugos~rt"
-      ]
+      }
     },
     {
       "id": "f-u9bw-siauliaibusturas",
diff --git a/feeds/transport.orgp.spb.ru.dmfr.json b/feeds/transport.orgp.spb.ru.dmfr.json
index 111d6c02..d7bb586f 100644
--- a/feeds/transport.orgp.spb.ru.dmfr.json
+++ b/feeds/transport.orgp.spb.ru.dmfr.json
@@ -10,13 +10,13 @@
     },
     {
       "id": "f-udt-петербургский~метрополитен",
+      "supersedes_ids": [
+        "f-udt-Петербургский~метрополитен"
+      ],
       "spec": "gtfs",
       "urls": {
         "static_current": "http://transport.orgp.spb.ru/Portal/transport/internalapi/gtfs/feed.zip"
-      },
-      "supersedes_ids": [
-        "f-udt-Петербургский~метрополитен"
-      ]
+      }
     }
   ],
   "operators": [

You can apply these changes by:

Using a code editor
Running transitland-lib locally
Waiting for a maintainer to help

Thank you for contributing to Transitland Atlas! 🚀

Onestop IDs shouldn't have capital letters

Loading
Loading status checks…

a23a218

drewda added 4 commits March 13, 2025 13:25

Merge branch 'main' into no-cap-onestop-ids

Loading
Loading status checks…

93833c9

script to convert feed Onestop IDs to lower case

bd44430

runt he script, but add some warnings

1c5dbe3

run the script

Loading
Loading status checks…

e351392

apply opinionated DMFR format

Loading
Loading status checks…

dc47dac

drewda merged commit 397dbb7 into main Mar 13, 2025
4 checks passed

drewda deleted the no-cap-onestop-ids branch March 13, 2025 20:45

1Maxnet1 mentioned this pull request Mar 14, 2025

Update transitland id for Estonian feed public-transport/transitous#1004

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onestop IDs shouldn't have capital letters #1256

Onestop IDs shouldn't have capital letters #1256

drewda commented Oct 3, 2024

drewda commented Oct 3, 2024

github-actions bot commented Mar 13, 2025

Onestop IDs shouldn't have capital letters #1256

Onestop IDs shouldn't have capital letters #1256

Conversation

drewda commented Oct 3, 2024

drewda commented Oct 3, 2024

github-actions bot commented Mar 13, 2025

DMFR Format Check Results

Suggested Changes: