Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse unsafe extern blocks #256

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

m4rch3n1ng
Copy link
Contributor

@m4rch3n1ng m4rch3n1ng commented Feb 28, 2025

fixes: #250

i couldn't find a way to properly resolve the conflict between unsafe extern "C" fn and unsafe extern "C" {} without adding them to the conflicts field for now. if you have an idea on how to do that better then i would like.

specified here, here and here

regarding #229:

diff
--- .tmp/list.txt	2025-02-28 16:16:12.002933806 +0100
+++ .tmp/list.txt.unsafe-extern-mod	2025-02-28 19:10:18.478498116 +0100
@@ -1,7 +1,6 @@
 tests/codegen/dst-offset.rs
 tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-user-defined-types.rs
 tests/codegen/function-arguments.rs
-tests/codegen/terminating-catchpad.rs
 tests/coverage/attr/nested.rs
 tests/coverage/coroutine.rs
 tests/coverage/coverage_attr_closure.rs
@@ -216,7 +215,6 @@
 tests/ui/parser/keyword-union-as-identifier.rs
 tests/ui/parser/parser-unicode-whitespace.rs
 tests/ui/parser/trait-plusequal-splitting.rs
-tests/ui/parser/unsafe-foreign-mod.rs
 tests/ui/pattern/issue-22546.rs
 tests/ui/pattern/usefulness/integer-ranges/issue-117648-overlapping_range_endpoints-false-positive.rs
 tests/ui/privacy/decl-macro-infinite-global-import-cycle-ice-64784.rs
@@ -230,8 +228,6 @@
 tests/ui/rust-2018/try-macro.rs
 tests/ui/rust-2018/uniform-paths/from-decl-macro.rs
 tests/ui/rust-2018/uniform-paths/macro-rules.rs
-tests/ui/rust-2024/unsafe-extern-blocks/extern-items.rs
-tests/ui/rust-2024/unsafe-extern-blocks/safe-items.rs
 tests/ui/simd/masked-load-store.rs
 tests/ui/sized/coinductive-1-gat.rs
 tests/ui/specialization/assoc-ty-graph-cycle.rs

@m4rch3n1ng m4rch3n1ng force-pushed the unsafe-extern-mod branch 5 times, most recently from 4c4cd80 to a29fc35 Compare March 6, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Missing parsing of safe/unsafe externs
1 participant