-
-
Notifications
You must be signed in to change notification settings - Fork 21
Implement gzgetc and gzgets #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The coverage report shows no calls to There also is an error in the wasm32 CI build, but I don't know enough about the environment to understand it:
|
wasmtime does not like the use of function pointers somehow?
I'm not entirely sure either, you can see the correct codecov by using:
|
According to the error for some reason part of the code gets compiled with wasm exceptions enabled. |
But if you look at the fix, I don't think that is true? I suspect it's a wasmtime bug that just shows up with that error message because it found some bytes it did not understand. |
here is a reproduction (if you run this with e.g. pub extern "C-unwind" fn gzgetc() -> i32 {
42
}
pub extern "C-unwind" fn gzgetc_() -> i32 {
gzgetc()
}
fn main() {
for gzgetc_fn in [gzgetc, gzgetc_] {
// gzgetc on a null file handle should return -1.
assert_eq!(gzgetc_fn(), -1);
}
} The use of function pointers in combination with |
|
No description provided.