Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own sqrt and log returning NaN for "correct" multi-thread behaviour #1781

Merged
merged 75 commits into from
Feb 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
562d79e
Introduce NaNMath for unsafe sqrt and log
DanielDoehring Dec 12, 2023
291b916
performance measurements
DanielDoehring Dec 12, 2023
0b68235
implement log myself
DanielDoehring Dec 12, 2023
dc839f7
Try out different log implementation
DanielDoehring Dec 13, 2023
9f3be79
remove NaNMath, own implementation
DanielDoehring Dec 18, 2023
f6de171
remove unrelated
DanielDoehring Dec 18, 2023
829c992
Update src/equations/compressible_euler_2d.jl
DanielDoehring Dec 18, 2023
7ee3742
Merge branch 'main' into NaNMath
DanielDoehring Dec 18, 2023
83e8b1e
NaNSqrt for quasi 1d CEE
DanielDoehring Dec 18, 2023
9931e04
fmt
DanielDoehring Dec 18, 2023
72fdb4a
Update src/auxiliary/math.jl
DanielDoehring Dec 18, 2023
ea9d394
Update src/auxiliary/math.jl
DanielDoehring Dec 18, 2023
8941e03
Update src/auxiliary/math.jl
DanielDoehring Dec 18, 2023
cac51a3
for comparison
DanielDoehring Dec 19, 2023
e9e633b
Merge branch 'NaNMath' of github.com:DanielDoehring/Trixi.jl into NaN…
DanielDoehring Dec 19, 2023
ead190b
Update src/auxiliary/math.jl
DanielDoehring Dec 19, 2023
d1131e6
Update src/auxiliary/math.jl
DanielDoehring Dec 19, 2023
8c7efd4
llvm version log
DanielDoehring Jan 10, 2024
91f5d3c
Catch ints in sqrt_
DanielDoehring Jan 10, 2024
7389439
Merge branch 'main' into NaNMath
DanielDoehring Jan 10, 2024
a9523d4
Use sqrt_ log_ everywhere
DanielDoehring Jan 10, 2024
af22566
docu
DanielDoehring Jan 10, 2024
7bbec8b
fmt
DanielDoehring Jan 10, 2024
35a32bb
replace in comment
DanielDoehring Jan 10, 2024
f308b77
try exporting nan funcs
DanielDoehring Jan 10, 2024
4f7fa49
enable SIMD again
DanielDoehring Jan 10, 2024
6547640
Bring back SIMD
DanielDoehring Jan 11, 2024
50fa9f1
doc
DanielDoehring Jan 11, 2024
2ce3fdd
Update src/auxiliary/math.jl
DanielDoehring Jan 11, 2024
8062e95
Update src/auxiliary/math.jl
DanielDoehring Jan 11, 2024
303c332
docstring fmt
DanielDoehring Jan 11, 2024
2242236
Merge branch 'main' into NaNMath
DanielDoehring Jan 11, 2024
23d3b45
Merge branch 'main' into NaNMath
DanielDoehring Jan 11, 2024
a77cfaf
remove redundant docstrings
DanielDoehring Jan 11, 2024
c2fb55c
no own names
DanielDoehring Jan 12, 2024
f9f46d3
fmt
DanielDoehring Jan 12, 2024
3a93ea3
revert unintended
DanielDoehring Jan 12, 2024
0e9ff77
revert
DanielDoehring Jan 12, 2024
a952ac4
remove unintended
DanielDoehring Jan 12, 2024
7d85892
revert
DanielDoehring Jan 12, 2024
c79ba8c
fmt
DanielDoehring Jan 12, 2024
5fd0563
comments
DanielDoehring Jan 12, 2024
4508c3c
Merge branch 'main' into NaNMath
DanielDoehring Jan 12, 2024
91c274e
Merge branch 'main' into NaNMath
DanielDoehring Jan 12, 2024
edc3e2d
update test vals
DanielDoehring Jan 14, 2024
4372108
test vals
DanielDoehring Jan 14, 2024
aec0375
test vals
DanielDoehring Jan 15, 2024
d74ffac
Preferences
DanielDoehring Jan 18, 2024
64751ed
Update Project.toml
DanielDoehring Jan 18, 2024
a415bc5
Update src/Trixi.jl
DanielDoehring Jan 18, 2024
f58b316
fmt
DanielDoehring Jan 18, 2024
5db9c6c
docstrings
DanielDoehring Jan 18, 2024
7a440c8
docstrings
DanielDoehring Jan 18, 2024
b8578db
docstrings
DanielDoehring Jan 18, 2024
ac94829
compat info
DanielDoehring Jan 18, 2024
0c7795c
Apply suggestions from code review
DanielDoehring Jan 19, 2024
35e0cf6
escape "
DanielDoehring Jan 19, 2024
847c014
fmt
DanielDoehring Jan 19, 2024
1b7a5d0
Merge branch 'main' into NaNMath
DanielDoehring Jan 19, 2024
df6222e
Merge branch 'main' into NaNMath
DanielDoehring Jan 22, 2024
2225446
Merge branch 'main' into NaNMath
DanielDoehring Jan 31, 2024
22a7cdc
Merge branch 'main' into NaNMath
DanielDoehring Jan 31, 2024
fc96d58
Merge branch 'main' into NaNMath
DanielDoehring Jan 31, 2024
74c72cb
Merge branch 'main' into NaNMath
DanielDoehring Feb 1, 2024
65d1b6d
Merge branch 'main' into NaNMath
ranocha Feb 6, 2024
a920e51
fix benchmarks configuration
ranocha Feb 7, 2024
e6cf76b
Merge branch 'main' into NaNMath
DanielDoehring Feb 7, 2024
2ca4984
Merge branch 'main' into NaNMath
DanielDoehring Feb 8, 2024
fef217d
Merge branch 'main' into NaNMath
ranocha Feb 21, 2024
74d9566
Merge branch 'main' into NaNMath
ranocha Feb 21, 2024
c5eee35
skip UUIDs in downgrade CI job
ranocha Feb 22, 2024
6c17cc8
Merge branch 'main' into NaNMath
ranocha Feb 22, 2024
3d0e108
Update src/auxiliary/math.jl
DanielDoehring Feb 22, 2024
fc22360
Update Project.toml
DanielDoehring Feb 22, 2024
0229017
Merge branch 'main' into NaNMath
DanielDoehring Feb 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into NaNMath
DanielDoehring authored Feb 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 02290178f8fe676364864aa45753315a61fcb872

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.