Improved Dockerfile layer caching #242
Closed
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintonb
force-pushed
the
clintonb/dockerfile
branch
from
d39b4b2 to
6a44e5e
Compare
All dependency installation happens before copying code. This ensures that simple code changes, without dependency changes, result in the cached dependency layers being reused during image rebuilds.
clintonb
force-pushed
the
clintonb/dockerfile
branch
from
6a44e5e to
326088d
Compare
|
@itsojon are you open to contributions? If so can you take review this and my other outstanding reviews? If not, can the README be updated stating as much? |
|
@andykimmay why was this closed? Are contributions not welcome? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All dependency installation happens before copying code. This ensures that simple code changes, without dependency changes, result in the cached dependency layers being reused during image rebuilds.
🔬 How to test
📸 Cypress Screenshots (if applicable)
Changes include