Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safeguard childlist mutations and empty strings #12

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Safeguard childlist mutations and empty strings #12

merged 5 commits into from
Feb 19, 2019

Conversation

jopdeklein
Copy link
Contributor

@jopdeklein jopdeklein commented Feb 14, 2019 •
edited
Loading

Should fix #6 and fix #11.

lucke84
lucke84 reviewed Feb 14, 2019
View reviewed changes
Copy link

@lucke84 lucke84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, mostly questions :)

@jopdeklein jopdeklein force-pushed the safeguard-childlist-mutations-and-empty-strings branch from ff41d79 to 16c9b68 Compare February 14, 2019 17:10
tryggvigy
tryggvigy requested changes Feb 18, 2019
View reviewed changes
Copy link
Owner

@tryggvigy tryggvigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to improve the project 🎉! I got one comment on an unintended breaking change. Otherwise this LGTM

@jopdeklein jopdeklein force-pushed the safeguard-childlist-mutations-and-empty-strings branch from 8e4c210 to 18828d7 Compare February 19, 2019 12:51
@jopdeklein jopdeklein force-pushed the safeguard-childlist-mutations-and-empty-strings branch from 18828d7 to e06aad8 Compare February 19, 2019 12:52
tryggvigy
tryggvigy approved these changes Feb 19, 2019
View reviewed changes
Copy link
Owner

@tryggvigy tryggvigy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll merge this and make a new release on npm when I get home from work.
Thanks again 👏

@tryggvigy tryggvigy merged commit 032c304 into tryggvigy:master Feb 19, 2019
@jopdeklein jopdeklein deleted the safeguard-childlist-mutations-and-empty-strings branch February 19, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucke84 lucke84 lucke84 left review comments

@tryggvigy tryggvigy tryggvigy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jopdeklein @lucke84 @tryggvigy