Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from nextauthjs:main #304

Merged
merged 10 commits into from
Jan 15, 2022
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 5, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

* fix: add eslintIgnore in package.json

* Let eslint runs in app, config + js files

* Add a separate tsconfig.eslint.json file

We want to run the lint command on `app`, `src` and `config`, but at the same time want `tsc` to compile files in `src` only. A separate `tsconfig.eslint.json` is a suitable solution to satisfy both `eslint` and `tsc`: https://github.com/typescript-eslint/typescript-eslint/blob/04d1f3e5492a26e6f81002e0b89d58ba7cf60adb/packages/parser/README.md
@pull pull bot added the ⤵️ pull label Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #304 (227ff22) into main (75ca097) will increase coverage by 3.36%.
The diff coverage is 14.74%.

❗ Current head 227ff22 differs from pull request most recent head aa0e820. Consider uploading reports for the commit aa0e820 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            main     #304      +/-   ##
=========================================
+ Coverage   9.90%   13.27%   +3.36%     
=========================================
  Files         84       90       +6     
  Lines       1403     1424      +21     
  Branches     395      378      -17     
=========================================
+ Hits         139      189      +50     
- Misses      1038     1224     +186     
+ Partials     226       11     -215     
Impacted Files Coverage Δ
src/core/errors.ts 0.00% <0.00%> (ø)
src/core/index.ts 0.00% <0.00%> (ø)
src/core/init.ts 0.00% <0.00%> (ø)
src/core/lib/assert.ts 0.00% <0.00%> (ø)
src/core/lib/callback-handler.ts 0.00% <0.00%> (ø)
src/core/lib/callback-url.ts 0.00% <0.00%> (ø)
src/core/lib/cookie.ts 0.00% <0.00%> (ø)
src/core/lib/csrf-token.ts 0.00% <0.00%> (ø)
src/core/lib/default-callbacks.ts 0.00% <0.00%> (ø)
src/core/lib/email/signin.ts 0.00% <0.00%> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71cb84...aa0e820. Read the comment docs.

ThangHuuVu and others added 3 commits January 8, 2022 00:43
* fix(providers): fix url and auth method for Kakao provider

* fix(providers): convert typescript - Kakao provider

fix(providers): convert typescript - Kakao provider

* chore(providers): use nested interface for consistency

Co-authored-by: Balázs Orbán <[email protected]>
csbok and others added 6 commits January 10, 2022 11:35
* fix(providers): refactor naver provider profile

fix(providers): refactor naver provider profile

* fix(providers): convert typescript - naver provider profile

fix(providers): convert typescript - naver provider profile

* chore(providers): use nested interface for consistency

Co-authored-by: Balázs Orbán <[email protected]>
* Added patreon provider - tested and working

* Update src/providers/patreon.js

Co-authored-by: Balázs Orbán <[email protected]>

* Update src/providers/patreon.js

Co-authored-by: Balázs Orbán <[email protected]>

* Update src/providers/patreon.js

Co-authored-by: Balázs Orbán <[email protected]>

* Update src/providers/patreon.js

Co-authored-by: Balázs Orbán <[email protected]>

* Switched to TS, restore .env.local, restore package.json as per comments on the PR

* chore: ran Prettier

Co-authored-by: Balázs Orbán <[email protected]>
* feat(providers): add support to Twitter OAuth 2.0

* docs: add docs comment

* chore: cleanup

* chore: remove comments

* chore: give warning for OAuth 2 for now
* feat: better out-of-the-box `id_token` detection

* fix: check for `scope` on correct endpoint

* chore: simplify internal typing
The link to providers list was 404 so updated to the correct link in document.
@devkadirselcuk devkadirselcuk merged commit a04af2b into turkdevops:main Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment