Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional close button; minor cleanups #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

driehuis
Copy link

Add a close button, inspired by the patch in #20, but with an example close button added to the arrows sprite, and (commented out) code in index.html that shows how to activate the close button. By default, the close button is not shown.

Also:

  • clean up whitespace (two lines were misindented, probably as a result of an earlier pull request).
  • Return a value consistently from showImage, hideOverlay and showOverlay, to quell error messages in the Javascript console on Firefox.
    Feel free to cherrypick from the commits (I wasn't aware that github pools new commits into an existing pull request).

@driehuis driehuis changed the title Minor cleanups Add optional close button; minor cleanups Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant