Skip to content

SketchMap#create improvements #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2013
Merged

SketchMap#create improvements #227

merged 1 commit into from
Oct 24, 2013

Conversation

andrewnguyen
Copy link
Contributor

  • Create heavyHitters, totalValue and table all at once instead of one by one
  • Instead of creating a new intermediate SketchMap for every k,v pair, only create one SketchMap for the whole sequence of data

@andrewnguyen
Copy link
Contributor Author

johnynek added a commit that referenced this pull request Oct 24, 2013
@johnynek johnynek merged commit d05247e into twitter:develop Oct 24, 2013
@johnynek
Copy link
Collaborator

any benchmarks here? Thanks for doing this.

@andrewnguyen
Copy link
Contributor Author

I don't have any comprehensive benchmarks saved, but the one I did was around ~4-10x speedup. (basically an order of magnitude change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants