Skip to content

Fix tests that were not actually running #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2015

Conversation

sid-kap
Copy link
Contributor

@sid-kap sid-kap commented Aug 20, 2015

These tests were not running due to improper mixing of Scalacheck and Scalatest props.

@sid-kap sid-kap force-pushed the tests_not_running branch from cde9340 to ed635be Compare August 20, 2015 23:00
ianoc added a commit that referenced this pull request Aug 21, 2015
Fix tests that were not actually running
@ianoc ianoc merged commit 26f554e into twitter:develop Aug 21, 2015
@sid-kap sid-kap deleted the tests_not_running branch August 21, 2015 16:04
@johnynek
Copy link
Collaborator

This shit constantly reminds me how easy it is to misuse scalatest and how dangerous test migrations are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants