Improve the build and test times and add Codecov.io #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 2.11 runs timed out after running the tests. Restarted them to see if this was transient. |
|
I think maybe the tests are just too slow when instrumentation is on. Maybe need to find slow tests. :/ |
johnynek
force-pushed
the
oscar/add-codecov_io
branch
from
c20036b to
45d141d
Compare
johnynek
changed the title
| @@ -373,6 +373,9 @@ abstract class CMSTest[K: CMSHasher: FromIntLike] extends WordSpec with Matchers | |||
| val EPS = 0.001 | |||
| val SEED = 1 | |||
|
|
|||
| private[this] val maxDepth = 70 | |||
There was a problem hiding this comment.
Use these in the changes to the Gens above?
There was a problem hiding this comment.
It's a different class and I didn't want to yak shave too much. Just want the minimal change to enable code coverage to work.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reduced the cost of the CMS tests that were dominating before with (probably needlessly) huge CMS allocations. I also turned down the sizes for QTree and SketchMap that were needlessly huge taking forever.
The hope is that this would expose #528 and shame us into fixing the issue.