Skip to content
This repository was archived by the owner on May 4, 2022. It is now read-only.

ci(travis): leverage commitlint travis helper #621

Merged

Conversation

ChristianMurphy
Copy link
Contributor

removes need for custom shell script to check commit messages.
moves greenkeeper-lockfile package into dev dependencies so updates can be tracked.


Contributor License Agreement adherence:

@ChristianMurphy
Copy link
Contributor Author

CI error is originating from https://github.com/marionebl/commitlint/pull/157
Upstream resolution coming soon.

@marionebl
Copy link

Chiming in here - the travis helper isn't quite ready for prime time yet. I am working out the kinks, tracking progress here: https://github.com/marionebl/commitlint/issues/99, testing reports welcome!

@ChristianMurphy
Copy link
Contributor Author

the travis helper now is a officially recommended method https://github.com/marionebl/commitlint/pull/215
Updating this PR to get it merge-able.

This is now supported since commitlint leverages cosmiconfig.
This keeps the configuration in the same place as the other linters
switch from commitlint config angular to commitlint config conventional.
Angular is currently in the process of rewriting their commit
conventions, the final standard may or may not line up with the
conventional commit standard.
@ChristianMurphy ChristianMurphy requested a review from a team December 28, 2017 17:02
@ChristianMurphy
Copy link
Contributor Author

AppVeyor failing on unrelated issue

[INFO] --- exec-maven-plugin:1.3.2:exec (npm install (initialize)) @ uportal-app-framework ---
npm ERR! path C:\projects\uportal-app-framework\node_modules\fsevents\node_modules
npm ERR! code EPERM
npm ERR! errno -4048
npm ERR! syscall scandir
npm ERR! Error: EPERM: operation not permitted, scandir 'C:\projects\uportal-app-framework\node_modules\fsevents\node_modules'
npm ERR!  { Error: EPERM: operation not permitted, scandir 'C:\projects\uportal-app-framework\node_modules\fsevents\node_modules'
npm ERR!   stack: 'Error: EPERM: operation not permitted, scandir \'C:\\projects\\uportal-app-framework\\node_modules\\fsevents\\node_modules\'',
npm ERR!   errno: -4048,
npm ERR!   code: 'EPERM',
npm ERR!   syscall: 'scandir',
npm ERR!   path: 'C:\\projects\\uportal-app-framework\\node_modules\\fsevents\\node_modules' }
npm ERR! 
npm ERR! Please try running this command again as root/Administrator.

@ChristianMurphy
Copy link
Contributor Author

@uPortal-Project/uportal-app-framework-committers I'm invoking lazy consensus on this task.
Barring any objections, I plan on merging this later today.

@ChristianMurphy ChristianMurphy merged commit 8e08800 into uPortal-Attic:master Jan 3, 2018
@ChristianMurphy ChristianMurphy deleted the ci/commitlint-travis branch January 3, 2018 15:57
@vertein vertein added this to the 8.0.0 milestone Jan 8, 2018
@apetro
Copy link
Contributor

apetro commented Jan 10, 2018

I'd prefer that lazy consensus invocations have a footprint on uportal-dev@.

@ChristianMurphy
Copy link
Contributor Author

I'd prefer that lazy consensus invocations have a footprint on uportal-dev@

😒
Lazy consensus is a way of clearing blockers.
I'm not fully onboard with encouraging it.
Ideally people should be reviewing, and leaving explicit 👍 or 👎.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants