Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement <DOMTextNode> to [exhaustively] satisfy <regexp> #165

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Implement <DOMTextNode> to [exhaustively] satisfy <regexp> #165

merged 1 commit into from
Jan 3, 2017

Conversation

papandreou
Copy link
Member

// cc @Munter

@coveralls
Copy link

coveralls commented Jan 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 95.152% when pulling 3dd798c on papandreou:feature/textNodeToSatisfyRegExp into d6514c0 on Munter:master.

@Munter
Copy link
Member

Munter commented Jan 3, 2017

That's a nice improvement on both performance and output :)

@Munter Munter merged commit 4e3f985 into unexpectedjs:master Jan 3, 2017
@Munter
Copy link
Member

Munter commented Jan 3, 2017

I guess that this is a major version bump, since the output changed?

@papandreou
Copy link
Member Author

I'd say patch or minor. Previously expect(textNode, 'to satisfy', regexp) would unconditionally throw, which (I believe) is a bug that nobody is likely to have relied on.

@Munter
Copy link
Member

Munter commented Jan 3, 2017

I'll release a patch

@Munter
Copy link
Member

Munter commented Jan 3, 2017

Released in v3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Munter