Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Unexpected 10.27, use expect.child #177

Merged
merged 3 commits into from
Apr 28, 2017
Merged

Update to Unexpected 10.27, use expect.child #177

merged 3 commits into from
Apr 28, 2017

Conversation

papandreou
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.19% when pulling 7ed97df on papandreou:feature/child into 1faedd5 on Munter:master.

@papandreou
Copy link
Member Author

Ping @Munter

@Munter
Copy link
Member

Munter commented Apr 28, 2017

Did the API change in a minor release? What's up with the exportType instead of addType?

@papandreou
Copy link
Member Author

It's a new feature in Unexpected 10.27.0, addType still works as well.

@papandreou
Copy link
Member Author

See unexpectedjs/unexpected#377

@Munter
Copy link
Member

Munter commented Apr 28, 2017

Nice

@Munter Munter merged commit 2f6a8b9 into unexpectedjs:master Apr 28, 2017
@papandreou
Copy link
Member Author

For unexpected-dom this would be a semver-major thing, though, as it no longer works with <10.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Munter