Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to satisfy diffs in node.js 4+ and add jsdom 10 compatibility #181

Merged
merged 3 commits into from
May 22, 2017
Merged

Fix to satisfy diffs in node.js 4+ and add jsdom 10 compatibility #181

merged 3 commits into from
May 22, 2017

Conversation

papandreou
Copy link
Member

@papandreou papandreou commented Apr 30, 2017 •
edited
Loading

@coveralls
Copy link

coveralls commented Apr 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 94.851% when pulling 7acee57 on papandreou:fix/node7 into 2f6a8b9 on Munter:master.

@Munter
Copy link
Member

Munter commented Apr 30, 2017

Ugh, contextify build errors. I had blissfully forgotten about those :(

@papandreou
Copy link
Member Author

papandreou commented Apr 30, 2017 •
edited
Loading

Not a regression, though.

If we're ready to part with node.js 4 and below on CI, I have another branch where I upgrade the jsdom dev top to v10. Forgot to push it, though.

@papandreou
Copy link
Member Author

Pushed it (on top of the commits in this PR): #182

Let's see how that fares, and then let's evaluate.

@Munter Munter merged commit 7acee57 into unexpectedjs:master May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Munter