Added a prettier setup #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
approved these changes
Mar 18, 2018
package.json
Outdated
| "unexpected-dom.js", | ||
| "unexpected-dom.min.js" | ||
| ], | ||
| "files": ["lib", "unexpected-dom.js", "unexpected-dom.min.js"], |
There was a problem hiding this comment.
Could we add .prettierignore and add package.json to it? In my experience, prettier will battle npm install --save, changing it back and forth.
| } | ||
| ] | ||
| } | ||
| }; |
There was a problem hiding this comment.
How about @gustavnikolaj's isTTY trick?
There was a problem hiding this comment.
Will look at it. Maybe I copied an older version :-S
sunesimonsen
force-pushed
the
ssimonsen/prettier
branch
from
a2b9a1e to
386aee9
Compare
sunesimonsen
force-pushed
the
ssimonsen/prettier
branch
from
386aee9 to
f3e6894
Compare
|
I'll just merge it as I have just addressed the feedback :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a the same kind of setup we have in unexpected.