Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully inspect subject when contain elements matching fails #197

Merged

Conversation

sunesimonsen
Copy link
Member

When to contain elements matching fails you usually don't get the details you need as the inspected output dot out sub trees deeper than 3 levels.

@coveralls
Copy link

coveralls commented Mar 18, 2018

Coverage Status

Coverage increased (+0.02%) to 93.786% when pulling 5ae0cbc on ssimonsen/full-inspect-to-contain-element-matching into ff70f84 on master.

Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We might want to use this trick in some other assertions as well.

@sunesimonsen
Copy link
Member Author

Looks good! We might want to use this trick in some other assertions as well.

I agree, I'm trying to do a spike at work where I'm using unexpected-dom to test React components, and this was annoying me, but I'll see what else I run into.

@sunesimonsen sunesimonsen merged commit 59e181c into master Mar 18, 2018
@sunesimonsen sunesimonsen deleted the ssimonsen/full-inspect-to-contain-element-matching branch March 18, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants