Support ignoring subtrees in to satisfy #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to use a special comment `<!--ignore-->` on the rhs. That was the least intrusive solution I could come up with. Using an `<ignore/>` element does not work as it is not a void element, so you would have to type `<ignore></ignore>` - that is a little too much ignore :-)
sunesimonsen
force-pushed
the
ssimonsen/ignore-subtrees
branch
from
18d9071 to
b331683
Compare
papandreou
reviewed
Mar 18, 2018
There was a problem hiding this comment.
Looks fine. Since it's not "elastic" I'd like to see how it works in the presence of whitespace text nodes, eg.
<div>
<span>foo</span>
<div>something we don't care about</div>
<span>bar</span>
</div>If you want to ignore the inner div in the above, I think you'd have to satisfy it against an HTML string where the whitespace between the nodes is exactly the same. So <div><span>foo</span><!--ignore--><span>bar</span></div> wouldn't work, it would have to be:
<div>
<span>foo</span>
<ignore>
<span>bar</span>
</div>This probably is probably already present with the existing to satisfy, though, but I think it's worse here because you'd assume that the <!--ignore--> eats up the whitespace differences, too.
test/unexpected-dom.js
Outdated
| @@ -1293,6 +1293,50 @@ describe('unexpected-dom', function() { | |||
| ' ]' | |||
| ); | |||
| }); | |||
|
|
|||
| describe('and it contain an <ignore/> tag', () => { | |||
|
Let's wait with documenting this till we know it is a good approach. If we merge it I'll try to use it on some real projects. |
papandreou
approved these changes
Mar 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You need to use a special comment
<!--ignore-->on the rhs. That was the least intrusive solution I could come up with. Using an<ignore/>element does not work as it is not a void element, so you would have to type<ignore></ignore>- that is a little too much ignore :-)