Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the draggable attribute & flesh out enumerated property support. #216

Merged
merged 4 commits into from
Sep 24, 2018
+91 −18
Merged

Fix the draggable attribute & flesh out enumerated property support. #216

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43fc8d9
Fix the draggable attribute & flesh out enumerated property support.
alexjeffburke Sep 24, 2018
6d70092
Simplify the invalid enumerated attribute check
sunesimonsen Sep 24, 2018
558fc95
Don't inspect the supported values as an array.
sunesimonsen Sep 24, 2018
1c97d3f
Simplify expect.fail statement
sunesimonsen Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify expect.fail statement
@sunesimonsen
sunesimonsen committed Sep 24, 2018
commit 1c97d3fbce8550325e5f5ed311a3ea0e179e2886
20 changes: 9 additions & 11 deletions lib/index.js
View file
Original file line number Diff line number Diff line change
@@ -1050,17 +1050,15 @@ module.exports = {

return bubbleError(function() {
if (indexOfEnumeratedAttributeValue === -1) {
expect.fail({
message: function(output) {
output
.text('Invalid expected value ')
.appendInspected(expectedAttributeValue)
.text('. Supported values include: ')
.appendItems(
enumeratedAttributeValues[attributeName],
', '
);
}
expect.fail(function(output) {
output
.text('Invalid expected value ')
.appendInspected(expectedAttributeValue)
.text('. Supported values include: ')
.appendItems(
enumeratedAttributeValues[attributeName],
', '
);
});
}